Repository navigation
Add Builder.sign_embeddable for stream-less signing - #369
Open
gillesdegottex wants to merge 1 commit into
Open
gillesdegottex wants to merge 1 commit into
gillesdegottex wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Adds
Builder.sign_embeddable(format): signs the manifest and returns themanifest store as raw bytes, without requiring the asset on disk.
This is useful when the asset is not available at signing time and its hash
is already known, ex. for creating a service that only sign the manifest without
the need of transferring the whole file that might be big.
The caller adds a
c2pa.hash.dataassertion to the manifest definitionwith the pre-computed hash and the byte range to exclude, and gets back
a store that can be inserted into the asset at that exact range.
The asset outside that range is bound by the hash.
Checklist
TO DOitems (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.