Skip to content

various fixes - #9393

Merged
tkoeppe merged 4 commits into
cplusplus:mainfrom
tkoeppe:isolex
Nov 19, 2026
Merged

tkoeppe merged 4 commits into
cplusplus:mainfrom
tkoeppe:isolex

Conversation

@tkoeppe

@tkoeppe tkoeppe commented Nov 19, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@tkoeppe
tkoeppe requested a review from jensmaurer November 19, 2026 02:09

@jensmaurer jensmaurer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly harmless

Comment thread source/lex.tex Outdated
\item preprocessing numbers;
\item character literals (including user-defined character literals);
\item string literals (including user-defined string literals);
\item preprocessing operators and punctuators;

@jensmaurer jensmaurer Nov 19, 2026 •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would keep the comma as a separator and keep the final "and" here.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh, ISO was very specific about that. If we wanted a comma, we would need to drop the leading colon. But that's something I can do.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But if we keep the colon, then ISO said to separate the list items with semicolons.

Do you actually prefer dropping the leading colon?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Editorial subcommittee subdecision: drop colon, use normal comma (and comma-and) list.

@jensmaurer

Copy link
Copy Markdown
Member

CWG3242 for the rephrasing of [expr.assign] p7; please remove from here.

@tkoeppe

tkoeppe commented Nov 19, 2026

Copy link
Copy Markdown
Contributor Author

CWG3242 for the rephrasing of [expr.assign] p7; please remove from here.

Dropped, thanks!

This is an external constraint imposed by the rules of C++, so the use
of "must" is appropriate.

Fixes ISO/CS 051 (C++26 DIS)
@tkoeppe
tkoeppe requested a review from jensmaurer November 19, 2026 15:50
@tkoeppe
tkoeppe merged commit 7927df4 into cplusplus:main Nov 19, 2026
2 checks passed
@tkoeppe
tkoeppe deleted the isolex branch November 19, 2026 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants