Skip to content

build: keep the umbrella header out of the source_group tree - #490

Merged
sgerbino merged 1 commit into
cppalliance:developfrom
sgerbino:pr/cmake-source-group-umbrella
Nov 19, 2026
Merged

sgerbino merged 1 commit into
cppalliance:developfrom
sgerbino:pr/cmake-source-group-umbrella

Conversation

@sgerbino

@sgerbino sgerbino commented Nov 19, 2026 •

Copy link
Copy Markdown
Collaborator

CMake 4.5 rejects a file passed to source_group(TREE <root>) that does not lie under <root>. The header glob also matches the umbrella header include/boost/capy.hpp, which sits beside the tree rather than in it, so configuring fails with "is not a prefix of file". GitHub's macOS runners and the docs job now ship CMake 4.5.0.

The umbrella header is already placed in its own group by the source_group("" FILES ...) line above, so it is now left out of the tree group. Nothing else changes: the header still belongs to the target, and every other TREE call in the repository only receives files under its own root.

Checked with CMake 4.4.5 locally: configure succeeds, and the trace shows the tree group no longer receives the umbrella header. CMake 4.5 itself was not available locally, so CI is the check there.

Summary by CodeRabbit

  • Chores
    • Updated project source grouping in the build configuration.

CMake 4.5 rejects a source_group(TREE) file that lies outside the tree's root, and the header glob also matches include/boost/capy.hpp, so configuring failed. The header is already grouped on its own.
@coderabbitai

coderabbitai Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The CMake source grouping keeps include/boost/capy.hpp with build/Jamfile and groups the remaining headers under include.

Changes: CMake source grouping

Layer / File(s) Summary
Header source grouping
CMakeLists.txt
include/boost/capy.hpp remains explicitly grouped with build/Jamfile and is excluded from the header list passed to source_group(TREE ...). The remaining headers are grouped under include.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Suggested reviewers: ashtum

Merge Risk: Minimal · up to 82d50

This change fixes IDE source grouping so that configuration works with newer CMake versions. It does not change build outputs or runtime behavior, and no merge-blocking risk is apparent.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title "build: keep the umbrella header out of the source_group tree" matches the change. The CMakeLists.txt change removes include/boost/capy.hpp from the source_group(TREE ...) file list, and the…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "build: keep the umbrella header out of the source_group tree" matches the change. The CMakeLists.txt change removes include/boost/capy.hpp from the source_group(TREE ...) file list, and the header keeps its own group with build/Jamfile. The title is specific, concise, and names the primary change.

Finishing Touches

Generate unit tests (beta)

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

A rabbit checks the headers in a row,
One stays with Jamfile, placed just so.
The rest sit under include,
Grouped as the CMake rules conclude.
Then off I hop, through leaves and snow.

Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between fef20c8 and 82d50d2.

Files selected for processing: 1

  • CMakeLists.txt

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@cppalliance-bot

Copy link
Copy Markdown

An automated preview of the documentation is available at https://490.capy.prtest3.cppalliance.org/index.html

If more commits are pushed to the pull request, the docs will rebuild at the same URL.

2026-11-19 16:51:34 UTC

@cppalliance-bot

Copy link
Copy Markdown

GCOVR code coverage report https://490.capy.prtest3.cppalliance.org/gcovr/index.html
LCOV code coverage report https://490.capy.prtest3.cppalliance.org/genhtml/index.html
Coverage Diff Report https://490.capy.prtest3.cppalliance.org/diff-report/index.html

Build time: 2026-11-19 17:07:42 UTC

@codecov

codecov Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.49%. Comparing base (fef20c8) to head (82d50d2).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #490      +/-   ##
===========================================
+ Coverage    98.47%   98.49%   +0.01%     
===========================================
  Files          135      135              
  Lines         7364     7364              
===========================================
+ Hits          7252     7253       +1     
+ Misses         112      111       -1     
Flag Coverage Δ
linux 98.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1 file with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fef20c8...82d50d2. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sgerbino
sgerbino merged commit 0397c71 into cppalliance:develop Nov 19, 2026
41 checks passed
@sgerbino
sgerbino deleted the pr/cmake-source-group-umbrella branch November 19, 2026 17:28
@github-project-automation github-project-automation Bot moved this from Backlog to Done in Beast2 Nov 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants