Repository navigation
build: keep the umbrella header out of the source_group tree - #490
Conversation
CMake 4.5 rejects a source_group(TREE) file that lies outside the tree's root, and the header glob also matches include/boost/capy.hpp, so configuring failed. The header is already grouped on its own.
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
|
An automated preview of the documentation is available at https://490.capy.prtest3.cppalliance.org/index.html If more commits are pushed to the pull request, the docs will rebuild at the same URL. 2026-11-19 16:51:34 UTC |
|
GCOVR code coverage report https://490.capy.prtest3.cppalliance.org/gcovr/index.html Build time: 2026-11-19 17:07:42 UTC |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #490 +/- ##
===========================================
+ Coverage 98.47% 98.49% +0.01%
===========================================
Files 135 135
Lines 7364 7364
===========================================
+ Hits 7252 7253 +1
+ Misses 112 111 -1
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
CMake 4.5 rejects a file passed to
source_group(TREE <root>)that does not lie under<root>. The header glob also matches the umbrella headerinclude/boost/capy.hpp, which sits beside the tree rather than in it, so configuring fails with "is not a prefix of file". GitHub's macOS runners and the docs job now ship CMake 4.5.0.The umbrella header is already placed in its own group by the
source_group("" FILES ...)line above, so it is now left out of the tree group. Nothing else changes: the header still belongs to the target, and every otherTREEcall in the repository only receives files under its own root.Checked with CMake 4.4.5 locally: configure succeeds, and the trace shows the tree group no longer receives the umbrella header. CMake 4.5 itself was not available locally, so CI is the check there.
Summary by CodeRabbit