Repository navigation
ci: treat an unpinned MSVC version as a floor - #491
Conversation
The check required the exact MSVC version in the matrix, but an unpinned job runs whatever toolset its image ships, and runners of one image can differ during a rollout: windows-2025-vs2026 currently has either 14.51 or 14.52. Each update failed the job on the runners that had moved ahead. An unpinned job now accepts its version or newer and logs a notice naming the toolset it got. A job that pins msvc-toolset still requires that exact version.
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
|
An automated preview of the documentation is available at https://491.capy.prtest3.cppalliance.org/index.html If more commits are pushed to the pull request, the docs will rebuild at the same URL. 2026-11-19 20:04:47 UTC |
|
GCOVR code coverage report https://491.capy.prtest3.cppalliance.org/gcovr/index.html Build time: 2026-11-19 20:16:23 UTC |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #491 +/- ##
===========================================
+ Coverage 98.47% 98.49% +0.01%
===========================================
Files 135 135
Lines 7364 7364
===========================================
+ Hits 7252 7253 +1
+ Misses 112 111 -1
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
The MSVC check in CI required the exact version named in the matrix. A job that doesn't pin
msvc-toolsetruns whatever toolset its image ships, though, and runners of one image can differ while an update rolls out. Right nowwindows-2025-vs2026runners have either 14.51 or 14.52, so the x64 job fails on whichever runners have moved ahead, and relabelling it would just fail the others.An unpinned job now accepts its labelled version or anything newer, and adds a notice naming the toolset it got, e.g.
MSVC 14.52 (label 14.51). A job that pinsmsvc-toolsetstill requires that exact version. An older compiler, the wrong architecture or a missing banner still fails the step.Tested locally against sample
clbanners: an unpinned 14.51 job passes on 14.51 and 14.52 and fails on 14.44 or an ARM64 compiler; a pinned 14.44 job fails on 14.52.Summary by CodeRabbit