Skip to content

ci: treat an unpinned MSVC version as a floor - #491

Merged
sgerbino merged 1 commit into
cppalliance:developfrom
sgerbino:pr/msvc-version-floor
Nov 19, 2026
Merged

sgerbino merged 1 commit into
cppalliance:developfrom
sgerbino:pr/msvc-version-floor

Conversation

@sgerbino

@sgerbino sgerbino commented Nov 19, 2026 •

Copy link
Copy Markdown
Collaborator

The MSVC check in CI required the exact version named in the matrix. A job that doesn't pin msvc-toolset runs whatever toolset its image ships, though, and runners of one image can differ while an update rolls out. Right now windows-2025-vs2026 runners have either 14.51 or 14.52, so the x64 job fails on whichever runners have moved ahead, and relabelling it would just fail the others.

An unpinned job now accepts its labelled version or anything newer, and adds a notice naming the toolset it got, e.g. MSVC 14.52 (label 14.51). A job that pins msvc-toolset still requires that exact version. An older compiler, the wrong architecture or a missing banner still fails the step.

Tested locally against sample cl banners: an unpinned 14.51 job passes on 14.51 and 14.52 and fails on 14.44 or an ARM64 compiler; a pinned 14.44 job fails on 14.52.

Summary by CodeRabbit

  • Chores
    • MSVC compiler checks now reject missing or older-than-requested versions. When a specific toolset is pinned, the compiler version must match exactly; otherwise, newer versions are accepted and reported as a notice.

The check required the exact MSVC version in the matrix, but an unpinned job runs whatever toolset its image ships, and runners of one image can differ during a rollout: windows-2025-vs2026 currently has either 14.51 or 14.52. Each update failed the job on the runners that had moved ahead. An unpinned job now accepts its version or newer and logs a notice naming the toolset it got. A job that pins msvc-toolset still requires that exact version.
@coderabbitai

coderabbitai Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The CI workflow now parses the MSVC version for the requested target. It rejects missing or lower versions, enforces an exact match for pinned toolsets, and accepts higher versions for unpinned toolsets with a notice.

Changes: MSVC CI Version Check

Layer / File(s) Summary
MSVC version validation
.github/workflows/ci.yml
The workflow parses the compiler version for the requested target. It rejects missing or lower versions and requires an exact match when MSVC_TOOLSET is pinned. For unpinned jobs, a higher version passes and produces a notice.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: mvandeberg

Merge Risk: Minimal · up to c74c0

This change only relaxes the CI compiler version check for unpinned jobs so newer MSVC toolsets pass. Pinned jobs and architecture checks remain strict. There is no production impact, and merge risk is minimal.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title "ci: treat an unpinned MSVC version as a floor" names the main change. The workflow now accepts the matrix MSVC version or newer when no toolset is pinned, and requires an exact match when M…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "ci: treat an unpinned MSVC version as a floor" names the main change. The workflow now accepts the matrix MSVC version or newer when no toolset is pinned, and requires an exact match when MSVC_TOOLSET is pinned. The title is specific and concise, and it matches the PR objectives about unpinned jobs treating the version as a floor.

Finishing Touches

Generate unit tests (beta)

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

A rabbit checks the compiler's tune,
And reads the version by the moon.
If pinned, it seeks an exact match,
If higher, it shares a notice patch.
The build hops on its way.

Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 0397c71 and c74c0f6.

Files selected for processing: 1

  • .github/workflows/ci.yml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@cppalliance-bot

Copy link
Copy Markdown

An automated preview of the documentation is available at https://491.capy.prtest3.cppalliance.org/index.html

If more commits are pushed to the pull request, the docs will rebuild at the same URL.

2026-11-19 20:04:47 UTC

@cppalliance-bot

Copy link
Copy Markdown

GCOVR code coverage report https://491.capy.prtest3.cppalliance.org/gcovr/index.html
LCOV code coverage report https://491.capy.prtest3.cppalliance.org/genhtml/index.html
Coverage Diff Report https://491.capy.prtest3.cppalliance.org/diff-report/index.html

Build time: 2026-11-19 20:16:23 UTC

@codecov

codecov Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.49%. Comparing base (0397c71) to head (c74c0f6).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #491      +/-   ##
===========================================
+ Coverage    98.47%   98.49%   +0.01%     
===========================================
  Files          135      135              
  Lines         7364     7364              
===========================================
+ Hits          7252     7253       +1     
+ Misses         112      111       -1     
Flag Coverage Δ
linux 98.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1 file with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0397c71...c74c0f6. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sgerbino
sgerbino merged commit 6a95690 into cppalliance:develop Nov 19, 2026
41 checks passed
@github-project-automation github-project-automation Bot moved this from Backlog to Done in Beast2 Nov 19, 2026
@sgerbino
sgerbino deleted the pr/msvc-version-floor branch November 19, 2026 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants