Repository navigation
feat: ask company pages for logo, website and description before the free boost - #7469
Merged
Merged
Conversation
…free boost - The free boost card shows a setup state while the page misses its logo, website or a description of 40+ characters (squadFreeBoost status "setup"); the readiness checklist leaves those rows out then. - The company page form asks for the website and sends it on create. - The browser no longer sends the Startups signup event (form submit or first visit to an agent-made page): daily-api sends it once the page is ready. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FodmVsY4PkAQPi2CsDQx8o
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Ido · project thread
Changes
Pairs with dailydotdev/daily-api#4675: a company page's free $100 boost and its ad conversions now wait until the page has a logo, a website and a description of at least 40 characters.
squadFreeBoostreturnssetup, the card on the company page says "Finish your page to unlock your $100 boost" and lists logo, website and description with a button for each (links to Manage > Details / Links). The readiness checklist above it leaves those three rows out while the card shows them./squads/new?company=1asks for the website (optional, bare domains gethttps://) and sends it withcreateSquad. The hint under the logo says the three items get the first post a $100 boost.COMPANY_PAGE_MIN_DESCRIPTION_LENGTH, mirrors daily-api).useTrackNewCompanyPage(first visit to an agent-made page) are gone. daily-api sends the event from the server once the page is ready, like the first post event.Deploy daily-api#4675 first: the API needs the
websiteargument oncreateSquad.Screenshots are in the project thread (Storybook: Features/Squads/Free boost setup, Company page creation).
Events
Removed: browser
CompleteRegistration(Meta) and the X Startups signup event on company page creation. The same events are sent server-side when the page is ready.Experiment
No.
Manual Testing
Storybook stories for the card (desktop + phone) and the form.
pnpm --filter webapp typecheck, sharedfeatures/squadstests and webapp tests pass.Generated by Claude Code
Preview domain
https://feat-free-boost-page-ready.preview.app.daily.dev