Skip to content

fix: finish social sign-in from in-app browsers outside the onboarding funnel - #7472

Open
idoshamun wants to merge 1 commit into
mainfrom
fix/callback-in-app-browser
Open

idoshamun wants to merge 1 commit into
mainfrom
fix/callback-in-app-browser

Conversation

@idoshamun

@idoshamun idoshamun commented Nov 22, 2026 •

Copy link
Copy Markdown
Member

Requested by Ido · project thread

Changes

  • In the Facebook app (FBAN/FBAV user agents), /callback only followed the return address that the reader onboarding funnel stores (auth_redirect). A social sign-in that started on the company page form or the Startups checkout has no stored address, so the page returned early and rendered nothing. Since 19 Nov, 3 mobile signups from Meta ads got stuck there, even though the server had signed them in.
  • /callback now runs the regular flow when there's no stored address. That flow broadcasts the auth result, closes the window, and falls back to the return path.
  • The Startups account step (company page form and checkout) stores its own return path (auth_return_path). This way the fallback brings founders back to the form instead of the reader onboarding. setAuthReturnPath moves from AgentClaim to onboarding/lib/utils so both can use it.
  • New test: a Facebook app sign-in with a stored return path lands on that path. I checked that it fails on the old callback.tsx.

No UI changes.

Events

No

Experiment

No


Generated by Claude Code

Preview domain

https://fix-callback-in-app-browser.preview.app.daily.dev

…g funnel

In the Facebook app, /callback only followed the return address the reader
onboarding funnel stores. A sign in from the company page form or Startups
checkout has none, so the page returned early and the user was left on a
blank /callback (3 mobile signups from Meta ads since 19 Nov, all signed in
on the server). Fall back to the regular flow when there is no stored
address, and have the Startups account step store its own return path so
founders come back to the form instead of the reader onboarding.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FodmVtj5wwfn3ZFzrpUY28
@idoshamun idoshamun self-assigned this Nov 22, 2026
@vercel

vercel Bot commented Nov 22, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
daily-webapp Ready Ready Preview Nov 22, 2026 3:54pm UTC
1 Skipped Deployment
Project Deployment Actions Updated
storybook Ignored Ignored Nov 22, 2026 3:54pm UTC

Request Review

This branch was successfully deployed

1 active deployment
Preview – daily-webapp — 340c1e5b Deployed Nov 22, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants