Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
After reconnect, a subscribe or unsubscribe request w/ 501 symbols can replay as
[1, 1]instead of[0, 1]. That tells the gateway to process the first chunk before the rest of the request arrives.The fix replays the original chunks and preserves their
is_lastflags. It clearsstartwhen replaying subscriptions so the client avoids requesting historical data again. No new dependencies.Fixes #143
Type of change
How has this been tested?
Both mock-gateway regression cases (subscribe and unsubscribe) failed on 0.90.0 and passed w/ the fix on Linux. The tests run w/o a live API key. The reconnect test module skips on Windows.
Checklist
git diff --checkpassesDeclaration
I confirm this contribution is made under an Apache 2.0 license and that I have the authority necessary to make this contribution on behalf of its copyright owner.