Repository navigation
Show arrays in Postgres format with the default data formats - #1664
Open
jayhemnani9910 wants to merge 1 commit into
Open
jayhemnani9910 wants to merge 1 commit into
jayhemnani9910 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
With the shipped config, array columns print as Python lists:
format_outputsetspreprocessorsto(format_numbers, format_arrays), then replaces the whole tuple with(align_decimals,)when nofloatformat is set, which is the default (float = ""in pgclirc). That dropsformat_arrays. Settingfloat = "g"makes arrays show as{a,b}, so the formatter is there but skipped. It's now kept:(align_decimals, format_arrays).Tested: new
test_format_output_arrays_without_float_formatfails without the change; full suite 2680 passed (2679 on main). In a pgcli session against PostgreSQL 17 with an empty pgclirc, the query above now shows{a,b}and{}.\T csvoutput has the same Python lists and also writes<null>and space-padded numbers; that part is left alone here.Checklist
changelog.rst.AUTHORSfile (or it's already there).pip install pre-commit && pre-commit install).