Skip to content

updated codebase, composer, workflow, tests - #52

Open
bidi47 wants to merge 5 commits into
4.0from
upgrade
Open

bidi47 wants to merge 5 commits into
4.0from
upgrade

Conversation

@bidi47

@bidi47 bidi47 commented Nov 5, 2026 •

Copy link
Copy Markdown
Member

mikey179/vfsstream was removed since it as only used for tests (no test reads or writes a file through vfsStream any more. It only produces a path string, and any string would do)
and the latest update was over 2 years ago

laminas/laminas-servicemanager was not used anywhere, so it was removed (the workaround used in dot-dependency-injection was not needed)

note:

  • php 8.6 cannot be installed because laminas-cli only supports up to php 8.5
  • we can consider also removing php 8.3, since the symfony packages need php >= 8.4.1

Signed-off-by: bidi <bidi@apidemia.com>
Signed-off-by: bidi <bidi@apidemia.com>
@codecov

codecov Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.20253% with 3 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (4.0@9447208). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/FileLocker.php 91.30% 2 Missing ⚠️
src/Application.php 94.44% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##             4.0      #52   +/-   ##
======================================
  Coverage       ?   98.29%           
  Complexity     ?       76           
======================================
  Files          ?        8           
  Lines          ?      176           
  Branches       ?        0           
======================================
  Hits           ?      173           
  Misses         ?        3           
  Partials       ?        0           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@arhimede

arhimede commented Nov 6, 2026

Copy link
Copy Markdown
Member

blocked by laminas/laminas-cli#171

Comment thread composer.json Resolved
@bidi47
bidi47 requested a review from alexmerlin November 9, 2026 13:17
Signed-off-by: bidi <bidi@apidemia.com>
Comment thread src/Command/DemoCommand.php Resolved
Comment thread config/autoload/cli.global.php Resolved
Comment thread composer.json Resolved
Signed-off-by: bidi <bidi@apidemia.com>
Comment thread .laminas-ci.json Outdated
"8.6": true
},
"backwardCompatibilityCheck": true
"backwardCompatibilityCheck": false

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why false?

@alexmerlin

Copy link
Copy Markdown
Member

Actually, you're right about $defaultName.
But, before removing it from everywhere, we need to find a different solution for registering commands in Admin, API and Queue.

Signed-off-by: bidi <bidi@apidemia.com>
@bidi47

bidi47 commented Nov 12, 2026

Copy link
Copy Markdown
Member Author

Actually, you're right about $defaultName. But, before removing it from everywhere, we need to find a different solution for registering commands in Admin, API and Queue.

it's best to keep them for now. i'll add an issue for api to look into this task after the packages are done. ideally, it should be a simple matter to revisit the packages with a minor update

@bidi47 bidi47 linked an issue Nov 13, 2026 that may be closed by this pull request

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bump PHP 8.6

3 participants