Skip to content

code refactor, updated composer, docs, workflow, tests - #73

Open
bidi47 wants to merge 2 commits into
6.0from
upgrade
Open

bidi47 wants to merge 2 commits into
6.0from
upgrade

Conversation

@bidi47

@bidi47 bidi47 commented Nov 11, 2026

Copy link
Copy Markdown
Member
  • updated composer
    • removed PHP 8.2
    • added PHP 8.6
    • psr/http-server-handler was added because the code uses RequestHandlerInterface
    • dotkernel/dot-log is only required when using the shipped log config
    • ErrorResponseGenerator is used automatically when registered in the container
    • updated phpunit/phpunit: ^12.5
  • updated docs
    • added v6
    • updated readme, security, changelog
  • code refactoring
  • updated tests, workflows, phpstan from level 5 to 8
    • added structarmed

Signed-off-by: bidi <bidi@apidemia.com>
@gitguardian

gitguardian Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
15736006 Triggered Bearer Token 7713e62 docs/book/v6/extra/header.md View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@bidi47
bidi47 requested a review from alexmerlin November 11, 2026 23:15
@alexmerlin

Copy link
Copy Markdown
Member

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.
🔎 Detected hardcoded secrets in your pull request

GitGuardian id GitGuardian status Secret Commit Filename
15736006 Triggered Bearer Token 7713e62 docs/book/v6/extra/header.md View secret
15736006 Triggered Bearer Token 7713e62 docs/book/v6/extra/header.md View secret
🛠 Guidelines to remediate hardcoded secrets

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Those are not real secrets, just examples to showcase the HeaderProcessor hiding sensitive parameters.

Comment thread .laminas-ci.json Resolved
Comment thread composer.json

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we use Mezzio\Middleware\ErrorResponseGenerator in src/ErrorHandlerFactory.php, why would mezzio/mezzio move to suggest?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it uses Mezzio\Middleware\ErrorResponseGenerator but only in name, so the package doesn't ened to be installed. the fallback is the ErrorResponseGenerator from Stratigility

in a real application (DK API), mezzio/mezzio is often required, so it's installed there

Comment thread composer.json Resolved
Signed-off-by: bidi <bidi@apidemia.com>
@codecov

codecov Bot commented Nov 12, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 98.29060% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 98.19%. Comparing base (631d491) to head (8bf38c4).

Files with missing lines Patch % Lines
src/LogErrorHandlerFactory.php 93.33% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                6.0      #73      +/-   ##
============================================
- Coverage     98.42%   98.19%   -0.23%     
- Complexity      117      124       +7     
============================================
  Files            20       20              
  Lines           317      333      +16     
============================================
+ Hits            312      327      +15     
- Misses            5        6       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bidi47 bidi47 linked an issue Nov 13, 2026 that may be closed by this pull request

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bump PHP 8.6

2 participants