Skip to content

Select: Fix accesibility (label combobox) and restore keyboard navigation - #435

Open
andreas-schultz wants to merge 29 commits into
developfrom
fix/selectAccessibility-CMEM-8156
Open

andreas-schultz wants to merge 29 commits into
developfrom
fix/selectAccessibility-CMEM-8156

Conversation

@andreas-schultz

Copy link
Copy Markdown
Contributor
  • Connect FieldItem labels, helper text, and messages to the non-filterable Select combobox.
  • Keep focus on the combobox and expose the active option to screen readers.
  • Restore predictable Enter, arrow key, Escape, and Tab behavior, with a visible focus indicator.
  • Add tests for accessible descriptions, option selection, and focus handling.

andreas-schultz and others added 4 commits October 2, 2026 17:30
…tion

- Connect FieldItem labels, helper text, and messages to the non-filterable Select combobox.
- Keep focus on the combobox and expose the active option to screen readers.
- Restore predictable Enter, arrow key, Escape, and Tab behavior, with a visible focus indicator.
- Add tests for accessible descriptions, option selection, and focus handling.
- Connect filterable Select search inputs to their listbox popups.
- Expose the labelled combobox without the duplicate inner button for non-filterable Selects in FieldItem.
- Restore button accessibility when a Select becomes filterable, and test both modes
Comment thread src/components/Form/FieldItem.tsx Resolved
Comment thread src/components/Form/FieldItem.tsx Resolved
Comment thread src/components/Select/Select.tsx Resolved
Comment thread src/components/Form/FieldItem.tsx Resolved
Comment thread src/components/Select/Select.tsx Resolved
andreas-schultz and others added 16 commits November 5, 2026 13:37
- Distinguish non-filterable comboboxes from filterable Select trigger buttons
- Exclude hidden inputs from automatic field connections
- Reuse generic label and description wiring and preserve custom label references
- Clean up generated attributes when the control target changes
- Add regression tests for Select discovery and mode changes
- Focus custom controls when their FieldItem label is clicked
- Preserve native label behavior and respect disabled controls
- Support Tab, Shift+Tab, Enter and Space on Select’s clear action
- Prevent clearing and tooltip updates from opening options or stealing focus
- Reuse Blueprint’s item comparison helper
- Add regression tests for label focus and keyboard navigation
…6' into fix/selectAccessibility-CMEM-8156-fix

@haschek haschek left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All commented issues are fixed in fix/selectAccessibility-CMEM-8156-fix, and a tiny bit more.

Comment thread src/components/Select/Select.tsx Resolved
Comment thread src/components/Form/FieldItem.tsx Resolved
Comment thread src/components/Form/FieldItem.tsx Resolved
Comment thread src/components/Select/Select.tsx Resolved
Comment thread src/components/Form/FieldItem.tsx Resolved
haschek
haschek previously approved these changes Nov 13, 2026
- Add a Storybook example for selecting existing and custom values
- Describe creation callbacks and accessible option IDs in the API
- Note how to disable creation for invalid queries
- Add usage and validation guidance to the agent reference
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants