Repository navigation
Select: Fix accesibility (label combobox) and restore keyboard navigation - #435
Open
andreas-schultz wants to merge 29 commits into
Open
andreas-schultz wants to merge 29 commits into
andreas-schultz wants to merge 29 commits into
Conversation
andreas-schultz
commented
Oct 2, 2026
Contributor
- Connect FieldItem labels, helper text, and messages to the non-filterable Select combobox.
- Keep focus on the combobox and expose the active option to screen readers.
- Restore predictable Enter, arrow key, Escape, and Tab behavior, with a visible focus indicator.
- Add tests for accessible descriptions, option selection, and focus handling.
…tion - Connect FieldItem labels, helper text, and messages to the non-filterable Select combobox. - Keep focus on the combobox and expose the active option to screen readers. - Restore predictable Enter, arrow key, Escape, and Tab behavior, with a visible focus indicator. - Add tests for accessible descriptions, option selection, and focus handling.
- Connect filterable Select search inputs to their listbox popups. - Expose the labelled combobox without the duplicate inner button for non-filterable Selects in FieldItem. - Restore button accessibility when a Select becomes filterable, and test both modes
haschek
requested changes
Nov 3, 2026
- Distinguish non-filterable comboboxes from filterable Select trigger buttons - Exclude hidden inputs from automatic field connections - Reuse generic label and description wiring and preserve custom label references - Clean up generated attributes when the control target changes - Add regression tests for Select discovery and mode changes
- Focus custom controls when their FieldItem label is clicked - Preserve native label behavior and respect disabled controls - Support Tab, Shift+Tab, Enter and Space on Select’s clear action - Prevent clearing and tooltip updates from opening options or stealing focus - Reuse Blueprint’s item comparison helper - Add regression tests for label focus and keyboard navigation
…ility-CMEM-8156-fix
…6' into fix/selectAccessibility-CMEM-8156-fix
haschek
requested changes
Nov 11, 2026
haschek
left a comment
Member
There was a problem hiding this comment.
All commented issues are fixed in fix/selectAccessibility-CMEM-8156-fix, and a tiny bit more.
…6-fix Fixes after Review (CMEM-8156)
…get, so that self-referencing buttons are not ignored by screenreaders, using self-reference on the select default target button
… handler only if it is not true
haschek
previously approved these changes
Nov 13, 2026
- Add a Storybook example for selecting existing and custom values - Describe creation callbacks and accessible option IDs in the API - Note how to disable creation for invalid queries - Add usage and validation guidance to the agent reference
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.