Skip to content

Go: Use DataFlowIntegration for local SSA flow - #23130

Draft
owen-mc wants to merge 5 commits into
github:mainfrom
owen-mc:go/data-flow-integration
Draft

owen-mc wants to merge 5 commits into
github:mainfrom
owen-mc:go/data-flow-integration

Conversation

@owen-mc

@owen-mc owen-mc commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Use the shared DataFlowIntegration library for Go’s local SSA flow, following the earlier migration to MakeSsa.

The change preserves Go’s existing field-sensitive barrier guards and closure-flow modelling.

The shared graph retains merge nodes and cycles that were previously flattened. Adapt interface dispatch and the impossible-interface-nil-check query to handle these without changing their intended behavior. Hide internal merge nodes from path explanations.

Also enable SSA consistency checks and fix spurious reads of select-receive assignment targets. Remaining single-input phi findings arise because Go adds synthetic uncertain reads at function exits to retain captured definitions. Those reads extend liveness onto paths where no local definition exists.

@github-actions github-actions Bot added the Go label Nov 13, 2026
@owen-mc
owen-mc force-pushed the go/data-flow-integration branch from f3daf4e to 135d102 Compare November 13, 2026 16:49
owen-mc and others added 5 commits November 18, 2026 16:45
Do not treat select-receive assignment targets or other pure lvalues as variable reads in EvalInstruction.reads, matching ReadInstruction.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
… merges

Record pre-migration behavior across SSA merges, loops, and captured overwrites before switching local SSA flow to DataFlowIntegration.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Propagate unknown or possibly nil origins through SSA cycles and uncertain writes in interface dispatch and nil checks, and exclude SSA phi definitions from cleartext logging variable sources.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Use the shared DataFlowIntegration library for local SSA flow while preserving Go's field-sensitive barrier guards and closure flow, hiding synthetic SSA merge nodes from paths, and defining SsaNode.getBasicBlock.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Enable shared SSA and DataFlowIntegration consistency queries and record the remaining capture-retention exit-read phi baselines.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant