Skip to content

C#: Update Microsoft.CodeAnalysis dependencies. - #23152

Merged
michaelnebel merged 2 commits into
github:mainfrom
michaelnebel:csharp/updateroslyn
Nov 18, 2026
Merged

michaelnebel merged 2 commits into
github:mainfrom
michaelnebel:csharp/updateroslyn

Conversation

@michaelnebel

@michaelnebel michaelnebel commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

In this PR we update the dependencies required for starting to implement support for C# 15 language features in the extractor. Pinning of the Microsoft.Build dependencies should be un-done, when we update the extractor to .NET 11. CoPilot helped in deciding the version pins.

  • Upgrade Roslyn packages to 5.12.0.
  • Update Microsoft.Build to 18.9.6, the latest release targeting net10.0, and pin its framework/utilities/string-tools packages to the same compatible release.
  • Update Basic.CompilerLog.Util (binary log) to 0.9.66.
  • Regenerate Paket-to-Bazel dependency metadata.

This change should be transparent - not adding a change-note.

DCA looks good.

  • Performance appears unaffected.
  • From the table "Unknown expression types, per source" it appears that the update might generally improve the build-mode: none extraction (only powershell seems worse, but this project is already known to wobble - so might also be an instance of that).

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

DCA results for the final Roslyn dependency set are missing, so changed results and potential regressions cannot yet be assessed.

1 open issue
What changed in this PR

Updates the C# extractor’s .NET dependencies to support upcoming C# 15 work while remaining compatible with the .NET 10 toolchain.

Changes:

  • Upgrades Roslyn packages to 5.12.0 and Basic.CompilerLog.Util to 0.9.66.
  • Updates Microsoft.Build and related packages to compatible 18.9.6 releases.
  • Regenerates the Paket lockfile and Bazel NuGet dependency metadata.
File Description
csharp/​paket.main.bzl Regenerates Bazel NuGet repository metadata, checksums, and dependency mappings for the updated package graph.
csharp/​paket.lock Records the resolved Paket dependency graph and upgraded direct and transitive package versions.
csharp/​paket.dependencies Updates direct Roslyn, compiler-log, and Microsoft.Build dependencies with compatible version pins.

Review effort: Lite (adaptive)

Comment thread csharp/paket.dependencies
nuget Microsoft.CodeAnalysis.CSharp 5.3.0
nuget Microsoft.CodeAnalysis 5.3.0
nuget Microsoft.Build 18.6.3
nuget Microsoft.CodeAnalysis.CSharp 5.12.0

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we should definitely run DCA.

@michaelnebel michaelnebel added the no-change-note-required This PR does not need a change note label Nov 18, 2026
@michaelnebel
michaelnebel marked this pull request as ready for review November 18, 2026 06:43
@michaelnebel
michaelnebel requested review from a team as code owners November 18, 2026 06:43
@michaelnebel
michaelnebel requested a review from hvitved November 18, 2026 09:48
@michaelnebel
michaelnebel merged commit a47aa3f into github:main Nov 18, 2026
18 checks passed
@michaelnebel
michaelnebel deleted the csharp/updateroslyn branch November 18, 2026 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C# no-change-note-required This PR does not need a change note

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants