Repository navigation
Bump msw from 2.15.0 to 3.0.4 in /extensions/ql-vscode - #4650
dependabot[bot] wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The MSW 3 bump leaves Jest unable to load its ESM modules and retains the renamed onUnhandledRequest option, breaking affected tests and leaving unhandled-request policies unmigrated.
2 open issues
1 file not reviewed
extensions/ql-vscode/package-lock.json: Generated file
What changed in this PR
Updates MSW, used for GitHub API mocking and tests in the CodeQL VS Code extension, from 2.15.0 to 3.0.3.
Changes:
- Raises the MSW dependency range to
^3.0.3. - Refreshes the lockfile for MSW 3 and its transitive dependencies, including updated runtime and peer requirements.
| File | Description |
|---|---|
extensions/ql-vscode/package.json |
Updates the declared MSW dependency. |
extensions/ql-vscode/package-lock.json |
Locks MSW 3.0.3 and updates its dependency tree. |
Review effort: Balanced (auto)
| "js-yaml": "^5.4.2", | ||
| "koffi": "^3.3.2", | ||
| "msw": "^2.15.0", | ||
| "msw": "^3.0.3", |
| "js-yaml": "^5.4.2", | ||
| "koffi": "^3.3.2", | ||
| "msw": "^2.15.0", | ||
| "msw": "^3.0.3", |
1b8e137 to
7a984ae
Compare
There was a problem hiding this comment.
🟡 Changes recommended
The MSW 3 upgrade leaves removed APIs in use and lacks Jest ESM transformation support, causing type-checking failures, ignored request-handling options, and test module-loading failures.
3 open issues
1 file not reviewed
extensions/ql-vscode/package-lock.json: Generated file
Review effort: Balanced (auto)
| "resolved": "https://registry.npmjs.org/msw/-/msw-2.15.0.tgz", | ||
| "integrity": "sha512-2wQAmKkQKxRuXvYJxVhPGG0wZNBQyD06oJvxqw90XqLvptdqxdlHrFUfEteKkpaNORX3Xzc+HtEl/q0nfmN2wQ==", | ||
| "hasInstallScript": true, | ||
| "version": "3.0.3", |
Bumps [msw](https://github.com/mswjs/msw) from 2.15.0 to 3.0.4. - [Release notes](https://github.com/mswjs/msw/releases) - [Changelog](https://github.com/mswjs/msw/blob/main/CHANGELOG.md) - [Commits](mswjs/msw@v2.15.0...v3.0.4) --- updated-dependencies: - dependency-name: msw dependency-version: 3.0.3 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
7a984ae to
cbbc5c9
Compare
Dependabot automationRetrying failed jobs once before Copilot investigation. If CI passes, this pristine PR remains eligible for automatic merging. |
Dependabot automationDiagnosis: The MSW’s v3 release notes confirm the rename to Local verification: On the unchanged checkout, Maintainer action: Either defer the major upgrade or undertake a coordinated migration: preserve bypass/error behavior with the new API, address Jest’s ESM handling, and choose a bundling approach that gives the interceptor a valid WASM URL and includes the asset in the packaged extension. Verify extension activation, interception and recording, then run the Linux and Windows integration and CLI suites. Human review and merge are required; CI was not retried. Automatic merging is blocked pending a maintainer decision. |

Bumps msw from 2.15.0 to 3.0.4.
Release notes
Sourced from msw's releases.
... (truncated)
Commits
9bbfe99chore(release): v3.0.46dd1302fix(worker): prevent the worker from going idle (#2830)ebffbd4fix(isCommonAssetRequest): addicoto common assets (#2829)28c74aachore: fix the typescript-nightly job to run (#2819)3560a94chore(release): v3.0.33818a81fix(HandlersController): dispose of reset handlers (#2810)d1fe8e6fix: expose network context onenablein network sources (#2809)22a4626test(node): add jsdom cors/preflight regression tests (#2808)a32ee31docs: add beehiiv to partners (#2805)501a591chore: update github social imageMost Recent Ignore Conditions Applied to This Pull Request