Repository navigation
Conversation
Start the handshake deadline before requesting a permit so a connection cannot wait indefinitely in the queue or for the peer to respond. Pass the same deadline to the handshaker RPC so time spent waiting for a permit counts toward the existing 20-second budget. Close the connection on timeout and cancel any queued permit request when the handshake handler is removed. Fixes grpc#13172
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An ALTS connection can stall while waiting for a handshake permit or for the peer to send its next frame. The existing 20-second deadline on the handshaker RPC does not close the connection in either case.
Start a 20-second deadline before requesting a permit and pass that same deadline to the handshaker RPC. If the handshake times out, report UNAVAILABLE so the transport closes the connection. When the handshake handler is removed, cancel the timer and either remove the pending permit request or return the acquired permit.
Fixes #13172