Skip to content

Explicitly fail build when we cannot decode persisted AddressPool. - #1238

Open
randomlogin wants to merge 1 commit into
lightningdevkit:mainfrom
randomlogin:nov-26-fail-on-undecodable-address-pool
Open

randomlogin wants to merge 1 commit into
lightningdevkit:mainfrom
randomlogin:nov-26-fail-on-undecodable-address-pool

Conversation

@randomlogin

@randomlogin randomlogin commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Fixes #1212.

As with other storage readings, we fail the build if we cannot read it (despite the fact that failing to read AddressPool is less severe than other failed readings).

NotFound stays a fresh pool: every node upgrading from v0.7.x has no record yet, and revealing fresh indices is correct for them.

Previously we continued build after failing to decode  persisted `AddressPool`,
it could lead to losing handed addresses. Now we explicitly fail the
build in that case.
@ldk-reviews-bot

ldk-reviews-bot commented Nov 16, 2026 •

Copy link
Copy Markdown

I've assigned @tnull as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Established wallets silently lose pooled addresses when the pool record is missing or undecodable

2 participants