Repository navigation
fix(sip): unmap an IPv4-mapped source address before matching allowed_addresses - #1989
Open
cosmin-staicu wants to merge 1 commit into
Open
cosmin-staicu wants to merge 1 commit into
cosmin-staicu wants to merge 1 commit into
Conversation
…_addresses A dual-stack listener reports an IPv4 peer as ::ffff:a.b.c.d, and netip prefixes never contain the mapped form of an IPv4 address. The default matcher therefore refused such a caller even when its address was listed. matchAddrMasksStrict already unmaps; do the same in matchAddrMasks. Signed-off-by: Cosmin Staicu <cosmin.staicu@uipath.com>
🦋 Changeset detectedLatest commit: 7225bc6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A dual-stack listener reports an IPv4 peer as
::ffff:a.b.c.d. A netip prefix never contains the mapped form of an IPv4 address, so the default matcher refuses that caller even when its address is inallowed_addresses.matchAddrMasksStrictalready callsip.Unmap(). This adds the same call tomatchAddrMasks, plus test cases for a mapped source against a single address, a range it falls in, and a range it falls outside.