Skip to content

fix(sip): unmap an IPv4-mapped source address before matching allowed_addresses - #1989

Open
cosmin-staicu wants to merge 1 commit into
livekit:mainfrom
UiPath:fix/sip-allowed-addresses-unmap
Open

cosmin-staicu wants to merge 1 commit into
livekit:mainfrom
UiPath:fix/sip-allowed-addresses-unmap

Conversation

@cosmin-staicu

Copy link
Copy Markdown

A dual-stack listener reports an IPv4 peer as ::ffff:a.b.c.d. A netip prefix never contains the mapped form of an IPv4 address, so the default matcher refuses that caller even when its address is in allowed_addresses.

matchAddrMasksStrict already calls ip.Unmap(). This adds the same call to matchAddrMasks, plus test cases for a mapped source against a single address, a range it falls in, and a range it falls outside.

…_addresses

A dual-stack listener reports an IPv4 peer as ::ffff:a.b.c.d, and netip
prefixes never contain the mapped form of an IPv4 address. The default
matcher therefore refused such a caller even when its address was listed.
matchAddrMasksStrict already unmaps; do the same in matchAddrMasks.

Signed-off-by: Cosmin Staicu <cosmin.staicu@uipath.com>
@changeset-bot

changeset-bot Bot commented Nov 16, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 7225bc6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@livekit/protocol Patch
github.com/livekit/protocol Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant