Repository navigation
ci: add manual workflow to bump livekit-ffi - #946
cloudwebrtc wants to merge 3 commits into
Conversation
|
👋 This PR has no changeset. If it should be released, add a markdown file under ---
"livekit-rtc": patch
---
Short description of the change, used in the release notes.
If this change doesn't need a release (docs, CI, tests), you can ignore this comment. |
There was a problem hiding this comment.
Devin Review found 1 potential issue.
1 flag not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)
| - patch | ||
| - minor | ||
| - major |
There was a problem hiding this comment.
🟡 Invalid changesets for non-main bump PRs
On a non-main dispatch, bump always produces a changeset that fails validation. Changeset validation requires RC bumps for these PRs, but every available choice requests a stable release.
Learn more
The workflow checks out the dispatch ref and uses github.ref_name as the PR base. GitHub permits dispatching workflows on non-main branches. All available bump types are stable releases, which changeset validation rejects for a non-main base using the RC-only check.
Example: A maintainer dispatches the workflow on a feature branch containing this workflow and selects a newer FFI version with patch. The workflow opens a PR against that feature branch. When CI runs, changeset validation rejects the generated stable bump.
Recommended fix: Reject non-main dispatches before generating changes, or offer RC bump types and validate the selection against the target branch before creating the PR.
Was this helpful? React with 👍 or 👎 to provide feedback.
Adds a
workflow_dispatchworkflow (Bump livekit-ffi) that automates the livekit-ffi bump PRs we've been doing by hand (e.g. #891, #822).What it does:
livekit-ffi/vX.Y.Zrelease inlivekit/rust-sdks, or theversioninput if given.livekit-rtc/rust-sdks/livekit-ffi/Cargo.tomland exits if there is nothing newer, or if a PR forbump/livekit-ffi-vXis already open.livekit-rtc/rust-sdkssubmodule to the tag and checks thatCargo.tomlmatches.livekit-rtc/livekit/rtc/_protowith the same protoc / mypy-protobuf versions asbuild-rtc.yml, and warns about.protofiles thatgenerate_proto.shdoes not list.livekit-rtcchangeset (bumpinput, defaultpatch).Bump to livekit-ffi/vXPR with release / compare links, the file stat and the release notes.Notes:
GITHUB_TOKEN, sopull_requestworkflows do not start on their own; close and reopen the PR to run CI.