Repository navigation
Conversation
TypeScript emits `Object` as the design type for union types such as `string[] | null`, which made @property.array throw for nullable arrays. Fixes loopbackio#8466 Signed-off-by: utsxvrai <utsavrai2115@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TypeScript emits
Objectas the design type for union types such asstring[] | nullorstring[] | undefined, so@property.arraythrew "can only decorate array properties" for nullable array properties. This acceptsObjectas well asArrayas the design type; non-array types likestringor a model class still throw.Trade-off: because TypeScript gives no type info for unions, a non-array union like
Product | nulldecorated with@property.arraywill now also pass this check instead of throwing. That seemed better than rejecting every nullable array, but happy to change it if you'd prefer a different approach.Fixes #8466
Checklist
npm testpasses on your machine (packages/repository: 417 passing)packages/cliwere updatedexamples/*were updated