Repository navigation
fix(ci): scope the picomatch audit exception to development dependencies - #129
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Let PR #128 and other pull requests run the audit while
picomatchawaits a patched release.Behavior / risk
The affected copies in
bun.lockare reachable through development tools. The production audit runs first with every advisory enabled. The full audit applies a temporary exception for one advisory and still blocks any other finding. Remove the exception once the lockfile contains no affected copies. GHSA-fc5q-39xc-vjpfValidation
1.4.4against the public npm registry. The unfiltered baseline reported the advisory.bun scripts/verify.ts full --step auditpassed with this change.bun test ./scripts/audit.test.ts ./scripts/verify.test.tspassed all 20 tests. Biome passed for both changed files.PR #128 can sync from
mainonce this lands.