Repository navigation
Add MIDI input - #281
Open
v10101a wants to merge 1 commit into
Open
Add MIDI input#281v10101a wants to merge 1 commit into
v10101a wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
catilac
self-requested a review
November 17, 2026 23:43
Contributor
|
amazing! just kicked off automated tests for you, and will do some hand testing. but looks good! |
tychedelia
requested changes
Nov 17, 2026
tychedelia
left a comment
Member
There was a problem hiding this comment.
Would you mind collapsing the new midi_input example into the midi example? Feel free to be as creative as you want here, we just want to show off both examples in a single example.
|
Visual regression: 1 changed of 43 cases
If these changes are intentional, add the baseline |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
currently libprocessing could only send MIDI, though #74 describes sending and receiving. This PR exposes nannou_midi's existing input in libprocessing, following existing MIDI output code in
processing_midiprocessing_midi:midi_list_input_ports(),midi_connect_input(),midi_disconnect_input(),midi_read()midi_read()returnsMidiMessageobjects with kind, channel, note/velocity, control/value.midi_connect_input()takes a port number or part of a name (e.g."IAC") and returns the port it connected toAdditionally, i added two examples
examples/midi_input.rs: receives midi notes and visualizes them as colored bars. receive midi cc changes and change bg brightness.crates/processing_pyo3/examples/midi_input.py: same as above, but in pythonI tested on macOS only (IAC loopback + unit tests).
Disclosure: used claude to help with coding