Skip to content

[3.27] Avoid evaluating simple view content queryset - #1468

Merged
jobselko merged 1 commit into
pulp:3.27from
gerrod3:patchback/backports/3.27/b1a17b05db29b76b32bb1342b7430383a84ab110/pr-1164
Nov 16, 2026
Merged

jobselko merged 1 commit into
pulp:3.27from
gerrod3:patchback/backports/3.27/b1a17b05db29b76b32bb1342b7430383a84ab110/pr-1164

Conversation

@gerrod3

@gerrod3 gerrod3 commented Nov 13, 2026

Copy link
Copy Markdown
Contributor

Backports the simple view optimization from #1164 to 3.27. Keeps the branch-specific queryset handling and avoids evaluating the content queryset in the conditional.\n\nTesting: Not run.

Backport the simple view optimization from pulp_python#1164.

Assisted By: Codex

cherry picked from commit b1a17b0
@coderabbitai

coderabbitai Bot commented Nov 13, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: bb8866de-a616-4aa4-8876-1a2ca65f08cc

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@jobselko
jobselko merged commit 5024a12 into pulp:3.27 Nov 16, 2026
15 checks passed
@patchback

patchback Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

Backport to 3.19: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply 5024a12 on top of patchback/backports/3.19/5024a12f05b60a523f2d8e38cee9f52c0e01d916/pr-1468

Backporting merged PR #1468 into 3.27

  1. Ensure you have a local repo clone of your fork. Unless you cloned it
    from the upstream, this would be your origin remote.
  2. Make sure you have an upstream repo added as a remote too. In these
    instructions you'll refer to it by the name upstream. If you don't
    have it, here's how you can add it:
    git remote add upstream https://github.com/pulp/pulp_python.git
    
  3. Ensure you have the latest copy of upstream and prepare a branch
    that will hold the backported code:
    git fetch upstream
    git checkout -b patchback/backports/3.19/5024a12f05b60a523f2d8e38cee9f52c0e01d916/pr-1468 upstream/3.19
    
  4. Now, cherry-pick PR [3.27] Avoid evaluating simple view content queryset #1468 contents into that branch:
    git cherry-pick -x 5024a12f05b60a523f2d8e38cee9f52c0e01d916
    
    If it'll yell at you with something like fatal: Commit 5024a12f05b60a523f2d8e38cee9f52c0e01d916 is a merge but no -m option was given., add -m 1 as follows instead:
    git cherry-pick -m1 -x 5024a12f05b60a523f2d8e38cee9f52c0e01d916
    
  5. At this point, you'll encounter some merge conflicts. You must
    resolve them in order to preserve the patch from PR [3.27] Avoid evaluating simple view content queryset #1468 as close to the
    original as possible.
  6. Once conflicts are resolved and git added, run:
    git cherry-pick --continue
    
  7. Push this branch to your fork on GitHub:
    git push origin patchback/backports/3.19/5024a12f05b60a523f2d8e38cee9f52c0e01d916/pr-1468
    
  8. Create a PR, ensure that the CI is green. If it's not — update it so that
    the tests and any other checks pass. This is it!
    Now relax and wait for the maintainers to process your pull request
    when they have some cycles to do reviews. Don't worry — they'll tell you if
    any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@gerrod3
gerrod3 deleted the patchback/backports/3.27/b1a17b05db29b76b32bb1342b7430383a84ab110/pr-1164 branch November 16, 2026 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants