Repository navigation
explicit parsing of timestamps for Solcast API changes - #2931
lorenzo-solcast wants to merge 2 commits into
Conversation
AdamRJensen
left a comment
There was a problem hiding this comment.
This look good to me. Thanks @lorenzo-solcast
| If all timestamps share the same UTC offset, that offset is kept; | ||
| otherwise the timestamps are converted to UTC. |
There was a problem hiding this comment.
@lorenzo-solcast Why would the timestamps not always have the same time zone offset?
Edit: I've realized afterward that this might occur when there is daylight saving time.
Could you elaborate on what the convention is in terms of the time zone? Does it always return in local time or?
There was a problem hiding this comment.
thanks for the review @AdamRJensen . You are right, there is no scenario where this would happen as you either specify the offset in the request or it defaults to utc, so the offset retuned from the request will be consistent across the data. Updated the PR.
|
I have introduced a change that will support the "testing" phase, so to allow specifying |
docs/sphinx/source/referencefor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).remote-data) and Milestone are assigned to the Pull Request and linked Issue.