Repository navigation
Conversation
Hey @WPTK! 🎉Thanks for opening your first pull request! We appreciate your If AI is used for any portion of this PR, you must vet the content Finally, be sure the PR description includes the PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pytest tests/bifacialstill passes)docs/sphinx/source/referencefor API changes (not applicable: no API change)docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:numor this Pull Request with `:pull:`num. Includes contributor name and/or GitHub username (link with:ghuser:user``).remote-data) and Milestone are assigned to the Pull Request and linked Issue.Documents the effect of
n_pvrowson edge effects and runtime in thepvfactors_timeseriesdocstring, using only what the issue describes (rows are infinite in length but finite in number; a smalln_pvrowsgives fully illuminated ground at low sun elevation and morning/afternoon rear-irradiance spikes; larger values reduce this but increase runtime significantly). Docstring and whatsnew only, +10/-1.AI disclosure: this change was drafted with Claude (AI assistance) and I have reviewed the text against the issue.