Repository navigation
Conversation
SAY-5
force-pushed
the
fix-local-class-constructor-signature-20261001
branch
2 times, most recently
from
October 25, 2026 06:07
8e88fbd to
c37de97
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #893 +/- ##
=======================================
Coverage 95.34% 95.34%
=======================================
Files 134 134
Lines 26762 26782 +20
=======================================
+ Hits 25516 25536 +20
Misses 1246 1246 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
SAY-5
force-pushed
the
fix-local-class-constructor-signature-20261001
branch
from
November 16, 2026 20:44
c37de97 to
3b24bbf
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changing a constructor signature raises
AttributeNotFoundErrorwhen its class is defined inside a function. The constructor lookup asks the parent function for an attribute, but the local class is stored in its scope.Resolve the class name through the parent scope. Tests cover selecting the class definition, initializer definition, constructor call, and explicit initializer call; they also verify isolation between same-named local classes and retain a class-nested constructor control.
Fixes #692
Validation
AttributeNotFoundError; all 43 change-signature tests pass with this change.git diff --checkpasses.Checklist
AI assistance: Codex assisted with the implementation, tests, review, and this description.