Repository navigation
Embed local SVG images as image/svg+xml - #2352
Open
NotAFlightRisk wants to merge 1 commit into
Open
NotAFlightRisk wants to merge 1 commit into
NotAFlightRisk wants to merge 1 commit into
Conversation
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This embeds local
.svgfiles asimage/svg+xml, so an SVG actually shows up when you use it for aCustomIconorImageOverlay. At the moment it goes in asdata:image/svg;base64,..., which isn't a registered type, and Chromium won't draw it. On 1.0.0 a 40x30 SVG marker and overlay both come out blank (0x0), and they're 40x30 with this change.Other extensions are left as they are. PNG and JPEG get away with the bare extension because Chromium sniffs raster image bytes (even
image/jpgrenders), but it doesn't do that for SVG.