Repository navigation
Conversation
…ables Add AWAITABLE_STATE_EXECUTING to guard each step of PyAsyncGenASend and PyAsyncGenAThrow while a call is running, instead of publishing ITER before the initial send or throw executes. Concurrent or reentrant calls on the same awaitable now raise ValueError without corrupting ag_running_async or closing an active operation.
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #160347
Summary
Async generator awaitables previously used
AWAITABLE_STATE_ITERboth while a call was executing and while it was suspended. Another call on the same awaitable could therefore take the resume path before the initial exception was delivered, or clearag_running_asyncwhile the original call was still active. This could cause a sharedaclose()awaitable to resume the generator instead of closing it. Same-thread reentry can also corrupt the awaitable's state in GIL-enabled builds.Add
AWAITABLE_STATE_EXECUTINGto give each call exclusive access to the awaitable until the step yields or finishes. Overlapping calls raise the existingValueErrorwithout changing the active operation's state.ag_running_asynccontinues to exclude other awaitables while the owning operation is suspended.The tests cover reentry, concurrent calls on shared awaitables, ownership across suspension, and existing argument handling for finished generators.
Testing
Tested on Windows x64 Debug builds:
test_asyncgen,test_generators,test_coroutines(262 tests passed).test_free_threading.test_async_generators(273 tests passed).-R 3:3:test_asyncgenandtest_free_threading.test_async_generators(114 tests passed, with no reference leaks reported).