Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changeset updates the test environment to run the test suite on PHP 8.6, like done in reactphp/stream#192.
The minimum
react/event-loopversion is now v1.6.0 with its PHP 8.5+ support (reactphp/event-loop#282), as versions before v1.5.0 use thespl_object_hash()function deprecated in PHP 8.6 (replaced by reactphp/event-loop#267). The Unix domain socket (UDS) tests from #168 and #263 now expect the "Address already in use" message PHP 8.6 reports (php/php-src#21328). The TLS tests from #87 now clear OpenSSL errors after closing the connection, like done in reactphp/http#555.The legacy PHP setup on Windows now uses Composer 2.2.30 for PHP < 5.5 instead of the insecure downloads from #306, as Composer 2.2.31+ fails there (composer/composer#13147), and installs VC 2012 for PHP 5.5 and PHP 5.6 until mlocati/powershell-phpmanager#142 is released.
Builds on top of #338, #330, #306, #263, #168, #87, reactphp/event-loop#282, reactphp/event-loop#267, reactphp/http#555 and reactphp/stream#192