Repository navigation
Conversation
Every single buffer access need to use `ptr + pos`, this is very error prone as it can easily be forgotten and the error will only surface with shared string, which aren't normally created by the test suite. Instead initialize `beg` and `pos` with the real buffer offset, and get rid of the `ptr` variable entirely.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every single buffer access need to use
ptr + pos, this is very error prone as it can easily be forgotten and the error will only surface with shared string, which aren't normally created by the test suite.Instead initialize
begandposwith the real buffer offset, and get rid of theptrvariable entirely.