Skip to content

Fix JRI builds on Windows - #356

Open
r-suzuki wants to merge 3 commits into
s-u:masterfrom
r-suzuki:fix-jri-windows-build
Open

r-suzuki wants to merge 3 commits into
s-u:masterfrom
r-suzuki:fix-jri-windows-build

Conversation

@r-suzuki

@r-suzuki r-suzuki commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

This PR fixes the Windows JRI build issues reported in #352 and #355.

Changes

  • Update configure.win to use src/jri/ instead of the old jri/ paths.
  • Restore the #ifndef Win32 guard around Rinterface.h, which was lost when the include was moved from Rinit.c to Rdecl.h in commit 54bfb36. For R 4.6.0 and later, explicitly declare R_ReadConsole on Windows.

Testing

Verified on Windows 11 with R 4.6.2 and R-devel 4.7.0 (r90914), using Rtools45 and Temurin JDK 11:

Additional testing

To verify the fix for the regression introduced by an earlier commit in this PR (d002383), I tested on macOS (Apple Silicon) with R 4.5.3 and R 4.6.2 using JDK 25. Package installation and JRI rtest succeeded on both versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant