Repository navigation
fix(temporal): stop a failing signal handler from wedging its workflow #569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
46 changes: 46 additions & 0 deletions
46
examples/tutorials/10_async/10_temporal/000_hello_acp/conftest.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| """Pytest setup for this tutorial's tests. | ||
|
|
||
| ``project.workflow`` reads environment variables when it is imported, so the offline tests need them set and | ||
| this tutorial's ``project`` package importable. Both are arranged here for this tutorial's tests only. Any | ||
| ``project`` package already imported (another tutorial's, in a session that collects several) is cleared before | ||
| and after them, and so is the SDK's cached ``EnvironmentVariables``, so this tutorial's workflow reads its own | ||
| values. | ||
| """ | ||
|
|
||
| from __future__ import annotations | ||
|
|
||
| import os | ||
| import sys | ||
| from collections.abc import Iterator | ||
|
|
||
| import pytest | ||
|
|
||
| TUTORIAL_DIR = os.path.dirname(os.path.abspath(__file__)) | ||
|
|
||
| # Values already set in the environment win. | ||
| ENV_DEFAULTS = { | ||
| "AGENT_NAME": "at000-hello-acp", | ||
| "ACP_URL": "http://localhost:8000", | ||
| "WORKFLOW_NAME": "at000-hello-acp", | ||
| } | ||
|
|
||
|
|
||
| def _forget_project_modules() -> None: | ||
| for name in [name for name in sys.modules if name == "project" or name.startswith("project.")]: | ||
| del sys.modules[name] | ||
|
|
||
|
|
||
| @pytest.fixture(autouse=True, scope="module") | ||
| def _tutorial_environment() -> Iterator[None]: | ||
| with pytest.MonkeyPatch.context() as patch: | ||
| for name, value in ENV_DEFAULTS.items(): | ||
| if not os.environ.get(name): | ||
| patch.setenv(name, value) | ||
| patch.syspath_prepend(TUTORIAL_DIR) | ||
| # EnvironmentVariables.refresh() keeps the first values it reads for the whole process. | ||
| patch.setattr("agentex.lib.environment_variables.refreshed_environment_variables", None) | ||
| _forget_project_modules() | ||
| try: | ||
| yield | ||
| finally: | ||
| _forget_project_modules() | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
46 changes: 46 additions & 0 deletions
46
examples/tutorials/10_async/10_temporal/010_agent_chat/conftest.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| """Pytest setup for this tutorial's tests. | ||
|
|
||
| ``project.workflow`` reads environment variables when it is imported, so the offline tests need them set and | ||
| this tutorial's ``project`` package importable. Both are arranged here for this tutorial's tests only. Any | ||
| ``project`` package already imported (another tutorial's, in a session that collects several) is cleared before | ||
| and after them, and so is the SDK's cached ``EnvironmentVariables``, so this tutorial's workflow reads its own | ||
| values. | ||
| """ | ||
|
|
||
| from __future__ import annotations | ||
|
|
||
| import os | ||
| import sys | ||
| from collections.abc import Iterator | ||
|
|
||
| import pytest | ||
|
|
||
| TUTORIAL_DIR = os.path.dirname(os.path.abspath(__file__)) | ||
|
|
||
| # Values already set in the environment win. | ||
| ENV_DEFAULTS = { | ||
| "AGENT_NAME": "at010-agent-chat", | ||
| "ACP_URL": "http://localhost:8000", | ||
| "WORKFLOW_NAME": "at010-agent-chat", | ||
| } | ||
|
|
||
|
|
||
| def _forget_project_modules() -> None: | ||
| for name in [name for name in sys.modules if name == "project" or name.startswith("project.")]: | ||
| del sys.modules[name] | ||
|
|
||
|
|
||
| @pytest.fixture(autouse=True, scope="module") | ||
| def _tutorial_environment() -> Iterator[None]: | ||
| with pytest.MonkeyPatch.context() as patch: | ||
| for name, value in ENV_DEFAULTS.items(): | ||
| if not os.environ.get(name): | ||
| patch.setenv(name, value) | ||
| patch.syspath_prepend(TUTORIAL_DIR) | ||
| # EnvironmentVariables.refresh() keeps the first values it reads for the whole process. | ||
| patch.setattr("agentex.lib.environment_variables.refreshed_environment_variables", None) | ||
| _forget_project_modules() | ||
| try: | ||
| yield | ||
| finally: | ||
| _forget_project_modules() |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.