Repository navigation
Conversation
- The spec test list asks for a destination that an assumed role creates. Only a unit test with a built identity covers it. - The new block assumes a role on the real Vault. The role session creates the destination that the role policy names, and the Get of the account shows the account ID in AccountId and Arn. Vault gives the account ID of the session, so that CloudServer does not give both sides of the check. - A second name answers AccessDenied and creates nothing. - The raw-node client does not send the session token yet, so both cases fail on this commit.
- makeRequest gives authCredentials.sessionToken to the Arsenal signer. The signer sends x-amz-security-token and signs it, so the raw-node tests can call with the temporary credentials of a role. - A caller with no session token gets the same request as before.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## epic/S3C-10971-bnaas-d1 #6384 +/- ##
========================================================
Coverage 88.30% 88.30%
========================================================
Files 217 217
Lines 14775 14775
========================================================
Hits 13047 13047
Misses 1728 1728
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spec: https://claude.ai/artifact/QhKsCqtGNzaVice35nvip9#bcc30d01-27db.m1yth80jczv.13451
What and why
AccountIdandArn, and that the role policy denies another name. Before, only a unit test with a built identity covered a role session.makeRequestpassesauthCredentials.sessionTokento the Arsenal signer, which sends and signsx-amz-security-token, so the raw-node tests can call with the temporary credentials of a role. A caller with no session token gets the same request as before.s3c-ft-testson the two new cases only, with InvalidAccessKeyId at the Create: red run. With the token signed, both pass: green run.