Repository navigation
CLDSRV-1007: enforce object lock in DeleteObjects regardless of bucket config - #6385
Open
francoisferrand wants to merge 1 commit into
Open
francoisferrand wants to merge 1 commit into
francoisferrand wants to merge 1 commit into
Conversation
DeleteObjects skipped the per-version lock check when the bucket is not object-lock enabled, while DeleteObject enforces it from the object metadata alone. Lock state can exist on such buckets when metadata is written below the API (e.g. DR replication), so locked versions could be deleted through DeleteObjects only. Both paths now behave the same; it changes nothing for objects without lock state. Issue: CLDSRV-1007
Contributor
Hello francoisferrand,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Contributor
Incorrect fix versionThe
Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:
Please check the |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
@@ Coverage Diff @@
## development/9.6 #6385 +/- ##
================================================
Coverage 90.78% 90.78%
================================================
Files 207 207
Lines 39020 39020
================================================
Hits 35425 35425
Misses 3595 3595
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DeleteObjects let you delete a locked version (retention or legal hold) as long as the bucket itself wasn't object-lock enabled. DeleteObject has never worked that way: it enforces the lock based on the object alone, whatever the bucket config. This brings DeleteObjects in line.
You can't get into that state through the S3 API, but it happens when metadata is written behind it, typically by replication, where the DR bucket isn't lock-enabled but the replicated objects still need to stay protected.
Objects without a lock are unaffected.
Issue: CLDSRV-1007