Repository navigation
Run the free-threaded suite on every PR - #170
Conversation
code-check.yml's test-coverage only runs 3.14, so a change that broke the abi3t extension or GIL-free operation surfaced in the next nightly rather than on its PR. Add the free-threaded-tests job from coverage.yml there too: 3.15t, check_accel_import.py, then the suite outside -m management with PYTHON_GIL=0. It deploys nothing and runs alongside test-coverage. The nightly copy stays, to catch dependency releases that land between PRs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
Summary
free-threaded-testsjob tocode-check.yml. It's the same job Run the full non-management suite nightly on free-threaded 3.15t #169 added to the nightlycoverage.yml: 3.15t,check_accel_import.py, thenpytest -m 'not management'withPYTHON_GIL=0.code-check.yml'stest-coverageonly runs 3.14, so until now a change that broke the abi3t extension or GIL-free operation only showed up in the next nightly. Now it fails on the PR.permissions: contents: read. It runs alongsidetest-coverage(about 5 minutes); the suite took about 1.5 minutes locally, so CI shouldn't get slower.To make it block merges, add
free-threaded-teststo the required checks formain.Test plan
free-threaded-testspasses on this PR. This is the first time the job has run on a GitHub runner.🤖 Generated with Claude Code
Note
Low Risk
CI workflow only; no runtime, auth, or application code changes.
Overview
Adds a
free-threaded-testsjob tocode-check.ymlso PRs exercise the same Python 3.15t path as the nightly workflow: SingleStore in Docker,check_accel_import.py, thenpytest -m 'not management'withPYTHON_GIL=0and the C extension (SINGLESTOREDB_PURE_PYTHON=0).Until now,
test-coverageonly used 3.14, so regressions in the abi3t extension or GIL-free behavior could slip through until the next nightly. This job fails those changes on the PR; the nightly job remains for dependency churn between merges. It uses read-only permissions and no management/cluster cleanup—only the Docker service.Reviewed by Cursor Bugbot for commit 39067e5. Bugbot is set up for automated code reviews on this repo. Configure here.
Summary by CodeRabbit