Skip to content

Run the free-threaded suite on every PR - #170

Merged
kesmit13 merged 1 commit into
mainfrom
pr-free-threaded-tests
Nov 20, 2026
Merged

kesmit13 merged 1 commit into
mainfrom
pr-free-threaded-tests

Conversation

@kesmit13

@kesmit13 kesmit13 commented Nov 20, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Adds a free-threaded-tests job to code-check.yml. It's the same job Run the full non-management suite nightly on free-threaded 3.15t #169 added to the nightly coverage.yml: 3.15t, check_accel_import.py, then pytest -m 'not management' with PYTHON_GIL=0.
  • code-check.yml's test-coverage only runs 3.14, so until now a change that broke the abi3t extension or GIL-free operation only showed up in the next nightly. Now it fails on the PR.
  • It needs only the Docker service: no clusters, no management token, permissions: contents: read. It runs alongside test-coverage (about 5 minutes); the suite took about 1.5 minutes locally, so CI shouldn't get slower.
  • The nightly copy stays, to catch dependency releases that land between PRs.

To make it block merges, add free-threaded-tests to the required checks for main.

Test plan

  • pre-commit (actionlint) passes
  • The steps match the nightly job, which passed locally on 3.15t with the GIL off (1043 passed, 38 skipped)
  • free-threaded-tests passes on this PR. This is the first time the job has run on a GitHub runner.

🤖 Generated with Claude Code


Note

Low Risk
CI workflow only; no runtime, auth, or application code changes.

Overview
Adds a free-threaded-tests job to code-check.yml so PRs exercise the same Python 3.15t path as the nightly workflow: SingleStore in Docker, check_accel_import.py, then pytest -m 'not management' with PYTHON_GIL=0 and the C extension (SINGLESTOREDB_PURE_PYTHON=0).

Until now, test-coverage only used 3.14, so regressions in the abi3t extension or GIL-free behavior could slip through until the next nightly. This job fails those changes on the PR; the nightly job remains for dependency churn between merges. It uses read-only permissions and no management/cluster cleanup—only the Docker service.

Reviewed by Cursor Bugbot for commit 39067e5. Bugbot is set up for automated code reviews on this repo. Configure here.

Summary by CodeRabbit

  • Tests
    • Added automated checks for the package’s compatibility with free-threaded Python, including native extension imports and MySQL protocol tests. These checks run against a Singlestore service with the Global Interpreter Lock disabled.

code-check.yml's test-coverage only runs 3.14, so a change that broke the
abi3t extension or GIL-free operation surfaced in the next nightly rather
than on its PR. Add the free-threaded-tests job from coverage.yml there
too: 3.15t, check_accel_import.py, then the suite outside -m management
with PYTHON_GIL=0. It deploys nothing and runs alongside test-coverage.

The nightly copy stays, to catch dependency releases that land between
PRs.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The CI workflow adds a Python 3.15t job. It checks the C extension import and runs MySQL protocol tests with the GIL disabled and the native extension enabled.

Changes: Free-threaded test workflow

Layer / File(s) Summary
Configure and run free-threaded tests
.github/workflows/code-check.yml
The new job starts a Singlestore service, installs Python 3.15t and dependencies, checks the C extension import, and runs MySQL protocol tests excluding management. It disables the GIL and enables the native extension and hidden Fusion features.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Possibly related PRs

Merge Risk: Minimal · up to 39067

This adds a CI job that runs the free-threaded Python test suite on every PR. It does not change product behavior. The job's first run on a GitHub runner will confirm it works, and the risk of merging is minimal.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title states the main change: the free-threaded test suite now runs on every pull request. The raw summary confirms the change adds a free-threaded-tests job to code-check.yml, which runs the MySQ…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title states the main change: the free-threaded test suite now runs on every pull request. The raw summary confirms the change adds a free-threaded-tests job to code-check.yml, which runs the MySQL protocol tests on Python 3.15t with PYTHON_GIL=0. The objectives describe the same goal, so the title matches the changeset.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 08b9a7f2-dfdb-49eb-9e0f-5592bc37dab2
Commits

Reviewing files that changed from the base of the PR and between db44c8e and 39067e5.

Files selected for processing: 1

  • .github/workflows/code-check.yml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@kesmit13
kesmit13 merged commit 04ad93d into main Nov 20, 2026
16 checks passed
@kesmit13
kesmit13 deleted the pr-free-threaded-tests branch November 20, 2026 14:01

This branch was previously deployed

1 inactive deployment
Base — 39067e55 Deployed Nov 20, 2026 by kesmit13 via free-threaded-tests #676
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant