Repository navigation
feat: add apps.managed.permissions.set method - #2052
Merged
Merged
Conversation
This was referenced Nov 18, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2052 +/- ##
=======================================
Coverage 84.64% 84.65%
=======================================
Files 118 118
Lines 14071 14080 +9
=======================================
+ Hits 11910 11919 +9
Misses 2161 2161 ☔ View full report in Codecov by Harness. |
Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
zimeg
force-pushed
the
zimeg-feat-apps-managed-permissions-set
branch
from
November 18, 2026 06:15
3cfb97d to
a8bd56e
Compare
zimeg
marked this pull request as ready for review
November 18, 2026 20:41
# Conflicts: # slack_sdk/web/async_client.py # slack_sdk/web/client.py # slack_sdk/web/legacy_client.py # tests/slack_sdk_async/web/test_web_client_coverage.py
WilliamBergamin
approved these changes
Nov 18, 2026
WilliamBergamin
left a comment
Contributor
There was a problem hiding this comment.
💯 Thanks @zimeg! Matches the docs.slack.dev spec exactly, and codegen.py reproduces the async and legacy clients with no diff.
Left two small comments, nothing blocking 🚀
| to the app's owner. | ||
| """ | ||
| kwargs.update({"app_id": app_id, "permissions": permissions}) | ||
| return self.api_call("apps.managed.permissions.set", params=kwargs) |
Contributor
There was a problem hiding this comment.
💯 praise: Same keyword-only pass-through shape as the sibling apps.* methods, sorted between icon and manifest, so it reads like it was always there.
Member
Author
|
🌟 Thanks for the kind reviews @cchensh, @WilliamBergamin and @mwbrooks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request adds the
apps.managed.permissions.setmethod to the Web API clients.apps_managed_permissions_settakes a requiredapp_idandpermissions, eithereveryoneorapp_owner. The token must be issued to the manager app that created the app.scripts/codegen.py, and the method is added to the Web API coverage test.This is the only pull request in the
apps.managedstack, so it's based onmain. It's in the B7 app settings batch. Related to #2014.apps.managed.permissions.set👈 this pull requestTesting
With a token issued to a manager app (
app_configurations:write), for an app that manager app created:client.apps_managed_permissions_set(app_id=..., permissions="everyone")and confirm the response has"permission_type": "everyone".permissions="app_owner"and confirm"permission_type": "named_entities"with the calling user inuser_ids.AsyncWebClientto check the generated async method.Live check: in an Enterprise sandbox enabled for managed apps, the org admin user token of a test app with
app_configurations:writeis a manager app token. With it,apps_manifest_createmade a managed app, and both calls returnedokfromWebClientandAsyncWebClient.everyonecame back as"permission_type": "everyone", andapp_owneras"named_entities"with the calling user inuser_ids. A token that isn't issued to a manager app returnsmanager_app_not_eligible, andpermissions="bogus"returnsinvalid_arguments(must be a valid enum value).Category
/docs(Documents)/tutorial(PythOnBoardingBot tutorial)tests/integration_tests(Automated tests for this library)Requirements
python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.shafter making the changes.🤖 Generated with Claude Code