Skip to content

fix(oauth): add async delete methods to the sqlite3 installation store - #2065

Merged
mwbrooks merged 1 commit into
mainfrom
fix-sqlite3-async-delete
Nov 18, 2026
Merged

mwbrooks merged 1 commit into
mainfrom
fix-sqlite3-async-delete

Conversation

@WilliamBergamin

Copy link
Copy Markdown
Contributor

Summary

This pull request adds async_delete_bot and async_delete_installation to SQLite3InstallationStore, a follow-up suggested in review on #2062.

  • The store wraps every other async method in its sync twin, but these two fell through to the base class's NotImplementedError, and so did async_delete_all, which calls them. An async Bolt app on this store failed on app_uninstalled and tokens_revoked and kept the tokens.
  • The two wrappers match the file and amazon_s3 stores. AsyncCacheableInstallationStore over sqlite3 is fixed too, since it delegates to these methods.

Testing

The new test_async_delete fails on main with NotImplementedError and passes on this branch. It runs the three calls Bolt's async uninstall listeners make: async_delete_installation, async_delete_bot, and async_delete_all.

Category

  • slack_sdk.web.WebClient (sync/async) (Web API client)
  • slack_sdk.webhook.WebhookClient (sync/async) (Incoming Webhook, response_url sender)
  • slack_sdk.socket_mode (Socket Mode client)
  • slack_sdk.signature (Request Signature Verifier)
  • slack_sdk.oauth (OAuth Flow Utilities)
  • slack_sdk.models (UI component builders)
  • slack_sdk.scim (SCIM API client)
  • slack_sdk.audit_logs (Audit Logs API client)
  • slack_sdk.rtm_v2 (RTM client)
  • /docs (Documents)
  • /tutorial (PythOnBoardingBot tutorial)
  • tests/integration_tests (Automated tests for this library)

Requirements

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I have signed the Salesforce CLA (required before your PR can be reviewed or merged).
  • I've run python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh after making the changes.

🤖 Generated with Claude Code

SQLite3InstallationStore wraps every async method in its sync twin except
async_delete_bot and async_delete_installation, so both (and async_delete_all,
which calls them) raised NotImplementedError. An async Bolt app on this store
failed on app_uninstalled and tokens_revoked and kept the tokens. Add the two
wrappers, matching the file and amazon_s3 stores.

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
@WilliamBergamin
WilliamBergamin requested a review from a team as a code owner November 18, 2026 20:32
@WilliamBergamin WilliamBergamin added bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented semver:patch oauth labels Nov 18, 2026
@codecov

codecov Bot commented Nov 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.64%. Comparing base (b041c02) to head (d5fea96).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2065      +/-   ##
==========================================
+ Coverage   84.60%   84.64%   +0.03%     
==========================================
  Files         118      118              
  Lines       14067    14071       +4     
==========================================
+ Hits        11901    11910       +9     
+ Misses       2166     2161       -5     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@mwbrooks mwbrooks left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Thanks @WilliamBergamin! Async Bolt apps on the sqlite3 store can finally clear their tokens on uninstall.

@mwbrooks
mwbrooks merged commit 770ca65 into main Nov 18, 2026
19 checks passed
@mwbrooks
mwbrooks deleted the fix-sqlite3-async-delete branch November 18, 2026 20:40
@zimeg zimeg added this to the 3.47.1 milestone Nov 18, 2026

@zimeg zimeg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM! Thanks for closing the async gap in the sqlite3 store @WilliamBergamin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented oauth semver:patch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants