Skip to content

fix(tx): accept wrapped XDR input in edit - #2809

Open
mangod12 wants to merge 1 commit into
stellar:mainfrom
mangod12:fix/tx-edit-wrapped-xdr
Open

mangod12 wants to merge 1 commit into
stellar:mainfrom
mangod12:fix/tx-edit-wrapped-xdr

Conversation

@mangod12

Copy link
Copy Markdown

Fixes #2773.\n\n x edit now reads the complete piped transaction and strips whitespace before Base64 XDR decoding, so wrapped input (for example output folded to 76 columns) is accepted. Includes a regression test using the transaction from the issue.\n\nValidation: git diff --check passes. The targeted Rust test could not run in this Windows environment because the MSVC linker (link.exe) is unavailable.

@github-project-automation github-project-automation Bot moved this to Backlog (Not Ready) in DevX Oct 18, 2026

Copy link
Copy Markdown
Author

@leighmcculloch This PR’s required workflows are all waiting in action_required, so CI has not run yet. Could someone with the needed permissions approve the fork workflow run and take a look at the change? The targeted test is also noted as not run locally because this Windows setup lacks the MSVC linker.

@mangod12
mangod12 force-pushed the fix/tx-edit-wrapped-xdr branch from fa542e7 to e86425a Compare November 17, 2026 21:53
@mangod12

Copy link
Copy Markdown
Author

Hi, I rebased this on the latest main so the CI runs are fresh (the old ones expired waiting for approval). Could a maintainer approve the workflows when you get a chance? Happy to change anything. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Backlog (Not Ready)

Development

Successfully merging this pull request may close these issues.

tx edit fails on transaction XDR that is wrapped across multiple lines

1 participant