Skip to content

test: Use public wording for the built-in agent - #44

Merged
johnxie merged 1 commit into
masterfrom
chore/public-text-cleanup
Nov 19, 2026
Merged

johnxie merged 1 commit into
masterfrom
chore/public-text-cleanup

Conversation

@johnxie

@johnxie johnxie commented Nov 19, 2026

Copy link
Copy Markdown
Member

Two test files and two code comments named the built-in Taskade agent by an internal name.

What changed:

  • The test titles now say "the built-in agent".
  • The agent name in the two test fixtures is now "Taskade EVE".
  • The comments in the Zapier agent search and the n8n agent list now say "the built-in agent".
  • The constant in src/searches/findAgent.ts is now BUILT_IN_AGENT_ID.

Not changed: the agent id value in the fixtures and the filters. The API returns that id for the built-in agent and the Prompt operation accepts it, so the code must keep it.

Checks:

  • Searched the tree for internal names and private details. The id value is the only remaining hit.
  • yarn lint passes locally. The CI of this pull request runs the build and the tests of both packages.

Copilot AI lite review requested due to automatic review settings November 19, 2026 00:25

Copilot AI left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues remain, and the changes preserve the API identifier and existing filtering and agent-selection behavior while updating public wording.

No open issues 🎉

What changed in this PR

Updates tests, comments, and the Zapier constant to use public wording for Taskade’s built-in agent while preserving the API-required identifier and behavior.

Changes:

  • Renames the built-in agent constant to BUILT_IN_AGENT_ID.
  • Updates Zapier and n8n test titles and fixtures to use “the built-in agent” and “Taskade EVE”.
  • Revises related comments without changing filtering or agent-selection behavior.
File Description
src/​test/​app.test.ts Updates the Zapier test wording and built-in agent fixture name.
src/​searches/​findAgent.ts Renames the built-in agent ID constant and revises related comments.
packages/​n8n-nodes-taskade/​test/​Taskade.node.test.ts Updates the n8n test wording and built-in agent fixture name.
packages/​n8n-nodes-taskade/​nodes/​Taskade/​Taskade.node.ts Revises the agent-listing comment while preserving existing filtering behavior.

Review effort: Lite

@johnxie
johnxie merged commit 6fc54a8 into master Nov 19, 2026
6 checks passed
@johnxie
johnxie deleted the chore/public-text-cleanup branch November 19, 2026 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants