Repository navigation
test: Use public wording for the built-in agent - #44
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain, and the changes preserve the API identifier and existing filtering and agent-selection behavior while updating public wording.
No open issues 🎉
What changed in this PR
Updates tests, comments, and the Zapier constant to use public wording for Taskade’s built-in agent while preserving the API-required identifier and behavior.
Changes:
- Renames the built-in agent constant to
BUILT_IN_AGENT_ID. - Updates Zapier and n8n test titles and fixtures to use “the built-in agent” and “Taskade EVE”.
- Revises related comments without changing filtering or agent-selection behavior.
| File | Description |
|---|---|
| src/test/app.test.ts | Updates the Zapier test wording and built-in agent fixture name. |
| src/searches/findAgent.ts | Renames the built-in agent ID constant and revises related comments. |
| packages/n8n-nodes-taskade/test/Taskade.node.test.ts | Updates the n8n test wording and built-in agent fixture name. |
| packages/n8n-nodes-taskade/nodes/Taskade/Taskade.node.ts | Revises the agent-listing comment while preserving existing filtering behavior. |
Review effort: Lite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two test files and two code comments named the built-in Taskade agent by an internal name.
What changed:
Not changed: the agent id value in the fixtures and the filters. The API returns that id for the built-in agent and the Prompt operation accepts it, so the code must keep it.
Checks: