Repository navigation
Update to use iterative polling (while loop) instead of recursion cursor - #154
Open
TriDuong-TD wants to merge 1 commit into
Open
TriDuong-TD wants to merge 1 commit into
TriDuong-TD wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cursor._do_execute() polled for job status by calling itself after each time.sleep(wait_interval). Every poll cycle added a stack frame, so a long-running job eventually exceeded Python's default recursion limit (1000) and raised RecursionError.
This PR replaces the recursion with a while self._rows is None: loop. Behavior is otherwise unchanged.
Background
A customer's production workflow failed on a long-running query.
A temporary workaround (sys.setrecursionlimit(10000)) has been shared with the customer. It only raises the ceiling, so jobs that run long enough would still fail.
Purpose
_do_execute()intdclient/cursor.pyto use iterative polling (while loop) instead of recursion.