Skip to content

docs(rf-web): add selector-drift triage - #16

Merged
manykarim merged 5 commits into
MarketSquare:mainfrom
ai94iq:docs/selector-drift
Nov 17, 2026
Merged

manykarim merged 5 commits into
MarketSquare:mainfrom
ai94iq:docs/selector-drift

Conversation

@ai94iq

@ai94iq ai94iq commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor

Adds a selector drift reference to rf-browser.

Verified: catalog, governance, plugin references and docs voice checks pass.

What this changes

Helps tell a test defect from an app defect, uses the locator order from the rf-browser skill, and reruns one failing test three times to call it flaky.

Review checklist

Tick each item, or write "n/a: " after it. Reviewers don't approve a PR
with an unticked item that has no reason (see CONTRIBUTING.md, "Review").

  • Purpose. Each new or changed skill and subagent says what it is for and when to use it, in its description. n/a: no skill description change, only a new reference
  • Supported versions. catalog.yaml lists the libraries and version ranges the content was checked against, and the Robot Framework range. n/a: no new library, catalog.yaml is unchanged
  • Examples. .robot examples pass robot --dryrun; Python examples run. n/a: no examples
  • Security-relevant changes. Hooks, scripts, MCP configuration, manifests, subagent tools and skill allowed-tools changes are listed below; the security gate passes, and any new baseline entry has a reason. n/a: no hook, script, manifest or tools change
  • Tool permissions. Every subagent declares an explicit tools list; no allowed-tools entry grants unrestricted shell access. n/a: no subagent or allowed-tools change
  • Documentation voice. Text follows the writing rules in CONTRIBUTING.md and passes the docs voice check.

Security-relevant changes

none

Add a reference for selector drift and flaky UI tests to rf-browser.
It covers telling a test defect from an app defect, locator choice
and the rerun rules for new tests.
@ai94iq
ai94iq requested a review from manykarim as a code owner November 15, 2026 07:48
@ai94iq

ai94iq commented Nov 15, 2026

Copy link
Copy Markdown
Contributor Author

Merge chain: #11, then #12, then #13, then #14, then #15, then #16.

All six merge into main cleanly in this order (dry run on 2026-11-15).

Apart from #13 and #15, the PRs do not depend on each other.

ai94iq and others added 3 commits November 15, 2026 17:48
Add selector-drift.md to the rf-browser 'When to read the references'
table and remove its link to locators.md, so references stay one level
deep. Mirrored in the rf-agentskills bundle.
The quick-reference row now gives the same locator order as the skill
(test id, then role). The pointer to another reference goes, since
references are linked only from SKILL.md, and step 3 names the
three-run flakiness check as its one exception. Regenerated with
python scripts/build-catalog.py.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FHEmzL3ErAhGQykKWDx2wP
@manykarim
manykarim merged commit 51ec999 into MarketSquare:main Nov 17, 2026
26 checks passed
@manykarim

Copy link
Copy Markdown
Collaborator

Thanks for the update, @ai94iq! 🎉 The triage steps are practical, and listing selector-drift.md in the "When to read the references" table was exactly right. I also checked the keywords (Get BoundingBox, Get Element Count, Scroll To Element), and they all exist in Browser.

I made a few small changes so I could merge it right away:

  • merged the current main into your branch;
  • changed the quick-reference row in plugins/rf-web/skills/rf-browser/SKILL.md to "stable locator (test id, then role); measure before any rerun", so it matches the order in the skill and in your reference;
  • removed the line in selector-drift.md that pointed to the locators reference. In our skills, references are linked only from SKILL.md, and your line 18 already gives the order;
  • added to step 3 that the three-run check in "New and flaky tests" is the one exception to "rerun only after you know what changed";
  • regenerated the bundle with python scripts/build-catalog.py.

All checks passed, and it's merged now.

One small note for future PRs: since you opened this, we published AI_POLICY.md, and the PR template now has an "AI assistance" section. On new PRs we'd love a line there whenever a tool did a substantial part of the work, plus the command that regenerated bundles/.

Thanks again!

ai94iq pushed a commit to ai94iq/robotframework-plugins that referenced this pull request Nov 20, 2026
Task 7.1 of both changes is done: CI on main, a local run of the
AGENTS.md checks, and contributor PRs MarketSquare#13-MarketSquare#16 on the new layout. The
findings are in each tasks.md; the one open policy question (PRs opened
before AI_POLICY.md) is answered in ai-contributor-docs design.md.

Archiving merges the deltas into openspec/specs: ten modified
requirements from repo-cleanup and the new contributor-guidance spec.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FHEmzL3ErAhGQykKWDx2wP
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants