Skip to content

Bump msw from 2.15.0 to 3.0.5 in /extensions/ql-vscode - #4661

Open
dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/npm_and_yarn/extensions/ql-vscode/msw-3.0.5
Open

dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/npm_and_yarn/extensions/ql-vscode/msw-3.0.5

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Nov 19, 2026

Copy link
Copy Markdown
Contributor

Bumps msw from 2.15.0 to 3.0.5.

Release notes

Sourced from msw's releases.

v3.0.5 (2026-11-11)

Bug Fixes

  • update @mswjs/interceptors to 0.45.11 (589c5cfcd743356d6ec2366cf0e984d8504eb1b8)
  • add handler to the "request:match" event (#2834) (8719ce23df5acf6c84108329bcad136205cb05d4) @​kettanaito

v3.0.4 (2026-11-06)

Bug Fixes

  • worker: prevent the worker from going idle (#2830) (6dd13026f08c1c85a9eb4fdbb3b5c59d0f2c079e) @​kettanaito
  • isCommonAssetRequest: add ico to common assets (#2829) (ebffbd4c7f5be0d4db625ed10812d58f82ed92d7) @​kettanaito

v3.0.3 (2026-10-10)

Bug Fixes

  • HandlersController: dispose of reset handlers (#2810) (3818a81c455a638eda1558558d8ae3cd17a34e55) @​kettanaito
  • expose network context on enable in network sources (#2809) (d1fe8e6e6e7eefce43746ee44802bc553731e951) @​kettanaito

v3.0.2 (2026-10-03)

Bug Fixes

  • vite: support virtual:msw imports in vitest (#2802) (e73c381e3adc0848fcf9a7ef291b614b06a0d92b) @​kettanaito

v3.0.1 (2026-09-30)

Bug Fixes

  • treat CONNECT requests as the transport mechanism (#2796) (7cad86a03b0ddb2efdec96ce8a49b0ed07d9f4dc) @​kettanaito

v3.0.0 (2026-09-28)

⚠️ BREAKING CHANGES

  • MSW is now ESM-only (#2765).
  • Deprecate support for Node.js v18 and v20 (#2729). The minimal supported Node.js version is v22.
  • msw/native is removed in favor of @msw/react-native.
  • Require TypeScript 5.9 as the minimal version.
  • Deprecate support for TypeScript 5.1 and 5.2 (#2730)
  • worker.stop() returns a Promise (#2724). Awaiting it is relevant only for in-flight critical scenarios.
  • graphql is now exported as msw/graphql (#2691). GraphQL is now handled as a proper optional peer dependency.
  • Removes the handleRequest() utility. Please use the defineNetwork() API instead.
  • GraphQLLinkHandlers type has been renamed to GraphQLLink.
  • The file:// requests now throw in Node.js as they normally do (not supported by fetch).
  • The Content-Length request header is now removed by bypass().

... (truncated)

Commits
  • ec5e877 chore(release): v3.0.5
  • 589c5cf fix: update @mswjs/interceptors to 0.45.11
  • 8719ce2 fix: add handler to the "request:match" event (#2834)
  • 9bbfe99 chore(release): v3.0.4
  • 6dd1302 fix(worker): prevent the worker from going idle (#2830)
  • ebffbd4 fix(isCommonAssetRequest): add ico to common assets (#2829)
  • 28c74aa chore: fix the typescript-nightly job to run (#2819)
  • 3560a94 chore(release): v3.0.3
  • 3818a81 fix(HandlersController): dispose of reset handlers (#2810)
  • d1fe8e6 fix: expose network context on enable in network sources (#2809)
  • Additional commits viewable in compare view

Most Recent Ignore Conditions Applied to This Pull Request
Dependency Name Ignore Conditions
msw [>= 1.a, < 2]

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [msw](https://github.com/mswjs/msw) from 2.15.0 to 3.0.5.
- [Release notes](https://github.com/mswjs/msw/releases)
- [Changelog](https://github.com/mswjs/msw/blob/main/CHANGELOG.md)
- [Commits](mswjs/msw@v2.15.0...v3.0.5)

---
updated-dependencies:
- dependency-name: msw
  dependency-version: 3.0.5
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
dependabot Bot requested a review from a team as a code owner November 19, 2026 13:15
@dependabot dependabot Bot added the Update dependencies Dependabot update PRs label Nov 19, 2026
Copilot AI adaptive review requested due to automatic review settings November 19, 2026 13:15

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The MSW 3 upgrade leaves ESM-only modules excluded from Babel transformation, causing CommonJS-based unit and VS Code test suites that load msw/node to fail during module loading.

1 open issue
1 file not reviewed
  • extensions/ql-vscode/package-lock.json: Generated file
What changed in this PR

Upgrades Mock Service Worker (MSW), used for HTTP mocking in the CodeQL extension, from 2.15.0 to 3.0.5.

Changes:

  • Updates the MSW dependency range to ^3.0.5.
  • Refreshes the lockfile for MSW 3 and its transitive dependencies, including its higher Node.js requirement.
File Description
extensions/​ql-vscode/​package.json Updates the declared MSW dependency.
extensions/​ql-vscode/​package-lock.json Locks MSW 3.0.5 and updates its dependency tree.

Review effort: Balanced (adaptive)

"js-yaml": "^5.4.2",
"koffi": "^3.3.2",
"msw": "^2.15.0",
"msw": "^3.0.5",
@codeql-ci-app

codeql-ci-app Bot commented Nov 19, 2026

Copy link
Copy Markdown
Contributor

Dependabot automation

Retrying failed jobs once before Copilot investigation. If CI passes, this pristine PR remains eligible for automatic merging.

Automation run

@github-actions github-actions Bot added the dependency-needs-review Dependabot automation state; remove only deliberately label Nov 19, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Dependabot automation

Diagnosis: The msw 2.15.0 → 3.0.5 upgrade is more than a small API migration. In Build Extension attempt 2, the Linux Build, Linux Test, and CLI Test jobs on Linux and Windows fail during compilation: UnhandledRequestStrategy is no longer exported and onUnhandledRequest is no longer accepted. Lint reports those errors plus three test call sites. The Linux Unit Test independently fails to parse MSW’s ESM; 66 suites pass and one fails to load. Windows Build, Test, and Unit Test were cancelled during installation, so their results are unknown.

MSW’s v3.0.0 release notes confirm the rename to onUnhandledFrame and ESM-only packaging. Its v3.0.5 manifest requires Node >=22.12 and TypeScript >=5.9; CI uses Node 22.21.1 and this checkout specifies TypeScript 5.9.3. The minimum supported VS Code extension-host runtime was not verified: the Electron release URL was denied. Web search was unavailable, so these are known upstream links instead.

Additional blocker: An exploratory API rename and Jest allowlist made type checking pass, but Jest then failed on import.meta.url in @mswjs/interceptors 0.45.12. Its upstream source uses that URL to load llhttp.wasm. The existing CommonJS bundle replaces import.meta with an empty object and does not package that WASM file. A local load of the exploratory bundle with a VS Code stub failed with TypeError: Invalid URL. Repair therefore also needs a build/packaging decision in gulpfile.ts, outside the permitted patch scope, and an ESM-compatible Jest approach.

Local checks: npm ci --no-audit --no-fund succeeded with engine warnings for jsdom and lint-staged. On the unchanged checkout, npm run check-types and the focused npm run test:unit -- --runInBand gh-api-client.test.ts failed as above. With exploratory changes, npm run check-types and npm run build passed, but the focused unit tests still failed on import.meta; npm run lint -- --quiet failed on exploratory formatting. Those source edits were reverted. Windows and VS Code/CodeQL integration tests were not run locally. Cleanup of generated ignored out and dist artifacts was denied; they reflect the reverted exploratory changes and should not be relied on.

Maintainer action: Defer merging until the team chooses and verifies an ESM/WASM packaging and Jest strategy, migrates the request-handling options while preserving bypass/error behavior, and tests scenario replay and recording in supported extension hosts. Run the relevant Linux, Windows, and CodeQL integration checks after that work. Human review and merge remain required; no CI retry was initiated.

Automatic merging is blocked pending a maintainer decision.

Automation run

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependency-needs-review Dependabot automation state; remove only deliberately Update dependencies Dependabot update PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant